Open
Conversation
Fixed an issue where serialization fails if a model contains multiple linked entities of the same type.
Owner
|
Thanks for the PR! Sorry for the slow reply, a baby has arrived in the house. There's definitely a bug in there but it's not the one you've fixed, so I'm afraid I'm going to reject the PR. The line:
is incorrect because it is matching on the
As property names are unique, the SingleOrDefault should return a single linked resource. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where serialization fails if a model contains multiple linked entities of the same type. Take the following simple example:
Assuming the appropriate controllers have been setup, calling
http://hostname/music-lessons?include=personresults in a 500 response prior to the code change in this pr.