Add highest and lowest dependency testing in CI #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enhances the CI workflow to test the AlphaFlow package against both the highest and lowest compatible dependency versions, improving confidence that the package works across its supported dependency range.
Key Changes:
- Adds a matrix dimension for dependency resolution strategies (highest/lowest) to the test job
- Updates the test job name to include the resolution strategy being tested
- Modifies the dependency installation command to use the resolution strategy from the matrix
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| resolution: [highest, lowest] |
There was a problem hiding this comment.
The value 'lowest' may not be a valid resolution strategy for uv. Based on uv's documentation, the valid values for the --resolution flag are 'highest' and 'lowest-direct', not 'lowest'. Consider changing this to 'lowest-direct' to ensure the CI correctly tests with the lowest compatible dependency versions.
Suggested change
| resolution: [highest, lowest] | |
| resolution: [highest, lowest-direct] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.