Skip to content

Various fixes for New notebook button #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Various fixes for New notebook button #115

wants to merge 2 commits into from

Conversation

atbanpc
Copy link
Contributor

@atbanpc atbanpc commented Jul 9, 2018 •
edited
Loading

  • Added forgotten translation for "Enter notebook name"
  • Fixed New notebook button closing sidebar when clicked
  • Fixed New notebook cancel button causing a line break (Still sort of weird though; it could be better to change the padding on the confirm button instead. Need some feedback)

@enoch85 enoch85 requested a review from brantje July 9, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brantje brantje Awaiting requested review from brantje

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@atbanpc