Partial fix for nested procedural filters in :has() selectors #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves support for nested procedural operators within :has() selectors, addressing issue brave#495. Changes: - Modified has_procedural_operator() to recursively check for procedural operators inside :has() arguments - Added logic to extract procedural operators like :has-text() when nested within :has() selectors - Improves parsing for filters like: ytd-rich-item-renderer:has(.style-scope:has-text(Members only)) Limitations: - Selectors with combinators inside :has() (e.g., :has(> span:has-text(...))) are not fully supported yet due to complexity in reconstruction - The extracted selector structure may not be optimal in all cases Fixes brave#495 (partial)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves support for nested procedural operators within :has() selectors, addressing issue #495.
Changes:
Limitations:
Fixes #495 (partial)