Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK-5238 Delayed init android docs #8397
base: develop
Are you sure you want to change the base?
SDK-5238 Delayed init android docs #8397
Changes from 5 commits
c32116d
3b35cca
6502af7
26849b7
310f674
3327630
538752b
e4d100e
79d143f
2091c69
ecc9c8f
3261b59
0a69341
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just going to comment here to make sure we don't forget to add the Android version once we have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on adding numbers to the subtitles? For example, Step 1: Enabling Delayed Initialization or 1. Enabling Delayed Initialization
I think this would help the reader understand that the steps flow together. This is also helpful for parity, because the Swift Docs uses numbered Steps)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really steps where they all need to be done. Each section is a different part of the feature. If there's numbers, I think users will think they need to do all the steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right that's true! Since there are cases where a user may never init afterwards, etc. I agree with having no numbers then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up: are certain steps required before completing other steps? i.e., maybe doing something like this:
(or something similar?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commenting to remember to link after relase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, this line:
seems to conflict with the line above it:
could i get some clarity here when you get the chance @chshapiro ? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Note: this has been removed it in the current commit. Please be sure to double-check my changes to ensure I'm still representing the original idea properly 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commenting to remember to add link after release