Skip to content

Conversation

@TannerRogalsky
Copy link

Mirrors the slice implementation. Improves ergonomics when comparing arrays.

Mirrors the slice implementation. Improves ergonomics when comparing arrays.
@brendanzab
Copy link
Owner

Oooh, nice! I wonder if we should put this under a feature flag 🤔 - approx is used pretty widely and I'm not sure how disruptive a MSRV bump would be to the ecosystem.

I also see that we're using Travis CI still - might need to switch to Github Actions 😅

@TannerRogalsky
Copy link
Author

@brendanzab Can't hurt. I've added an array_impl that is not enabled by default.

@RReverser
Copy link

Would love to see this merged to get rid of all the &arr[..] in approx calls.

@kanerogers
Copy link

Hey there! Just giving this one a gentle bump! Anything else needed to get this closed?

wrt MSRV bump, might make sense to just bump the version to 0.6?

@jonaspleyer
Copy link

Hey there. I have forked the approx crate under https://crates.io/crates/approxim. I have already included many PRs of the original approx crate such as #57, #67, #69, #83, #87, #90, #91, #92. As you can see, this PR was included as well. This new crate approxim should work as a drop-in-replacement for approx. Feel free to try it out and let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants