Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial docker/kubernetes/helm support #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CPlusPlus17
Copy link

Initial docker support with helm chart. I also refactored rabbitmq to use authentication.
Please let me know your feedback.

@nerdalertdk
Copy link
Contributor

nerdalertdk commented Feb 24, 2025

Hi

Instead of changing so many OTS files. You can fix most of the problems with a init script.
You are welcome to see how I got ENV support for my docker image here
https://github.com/milsimdk/ots-docker-image/blob/main/entrypoint.d/__init__.py

I'm not fully in the k8s world yet, but you will likely run into file permissions when running as non-root or not setting UID/GIU on the container user, I tried with my setup initially.

When the "local" folder and app user don't have the same UID/GIU many reported problems with permissions.
milsimdk/ots-docker#1

https://github.com/milsimdk/ots-docker/blob/main/compose.override.yaml-example

@308Hunter
Copy link

308Hunter commented Feb 24, 2025 via email

@CPlusPlus17
Copy link
Author

Hi

Instead of changing so many OTS files. You can fix most of the problems with a init script. You are welcome to see how I got ENV support for my docker image here https://github.com/milsimdk/ots-docker-image/blob/main/entrypoint.d/__init__.py

I'm not fully in the k8s world yet, but you will likely run into file permissions when running as non-root or not setting UID/GIU on the container user, I tried with my setup initially.

When the "local" folder and app user don't have the same UID/GIU many reported problems with permissions. milsimdk/ots-docker#1

https://github.com/milsimdk/ots-docker/blob/main/compose.override.yaml-example

Thanks for the very good input. I like the solution with the init file, I'll adopt it.
In regards to the file permissions, as default pvc in kubernetes, the volume has the correct permission. But in some aks environments or host-mounts this can surly lead to problems. Normally the user is in charge to add a side car to handle the environment restrictions. But I'll add a sample side car which takes care of setting the proper file permissions.

@nerdalertdk
Copy link
Contributor

Hi
Instead of changing so many OTS files. You can fix most of the problems with a init script. You are welcome to see how I got ENV support for my docker image here https://github.com/milsimdk/ots-docker-image/blob/main/entrypoint.d/__init__.py
I'm not fully in the k8s world yet, but you will likely run into file permissions when running as non-root or not setting UID/GIU on the container user, I tried with my setup initially.
When the "local" folder and app user don't have the same UID/GIU many reported problems with permissions. milsimdk/ots-docker#1
https://github.com/milsimdk/ots-docker/blob/main/compose.override.yaml-example

Thanks for the very good input. I like the solution with the init file, I'll adopt it. In regards to the file permissions, as default pvc in kubernetes, the volume has the correct permission. But in some aks environments or host-mounts this can surly lead to problems. Normally the user is in charge to add a side car to handle the environment restrictions. But I'll add a sample side car which takes care of setting the proper file permissions.

Did suspect kubernetes did something smart with permissions, so that's great.
I'm also assuming most people running k8s got permissions under control :)

You are more then welcome to just use my image, have one for both OTS and OTS-UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants