Add CI workflow to run tests and type checking - #3
Merged
Conversation
Adds a GitHub Actions workflow that runs on pull requests and pushes to main. The workflow installs dependencies, runs type checking, and executes tests to ensure code quality before merging. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Bun has a known bug where it may crash during cleanup after tests pass. This matches the approach used in publish.yml. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Instead of blindly ignoring all test step failures, parse the output to check if tests actually passed. CI will now fail if: - Any tests fail (e.g., "1 fail" in output) - Tests don't run at all (no "pass" in output) CI will pass if tests succeed but Bun crashes during cleanup. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The CI was failing because Bun 1.3.6 has known segfault bugs on Linux during test cleanup. These crashes happen after tests pass, not during actual test execution. Changes: - Pin Bun to 1.3.3 (matches local dev version) in both workflows - Update publish.yml to use proper test output validation instead of blindly ignoring failures with continue-on-error See: oven-sh/bun#22452 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Simplify workflows to just run tests directly. If Bun 1.3.3 still crashes, we need to dig deeper into the root cause. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Testing with an older version that predates the timer cleanup bugs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Root cause: Bun 1.2.0+ introduced a regression where the test runner segfaults during timer callback cleanup after tests complete. The crash happens in NodeTimerObject.cpp during the timer draining sequence, not during test execution itself. Testing confirmed: - 1.1.39: passes - 1.1.45: passes (latest 1.1.x) - 1.2.10: crashes - 1.3.3: crashes - 1.3.6: crashes Using 1.1.45 as it's the newest version without this bug. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1.1.45 showed intermittent crashes, reverting to 1.1.39 which passed consistently in earlier tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CI workflow to run tests and type checking on pull requests and pushes to main.
Root Cause Investigation
Bun 1.2.0+ has a regression where the test runner segfaults during timer callback cleanup after tests complete on Linux. The crash happens in
NodeTimerObject.cppduring the timer draining sequence, not during actual test execution.Testing results:
Solution: Pin Bun to 1.1.39, the newest version without this bug.
Changes
.github/workflows/ci.ymlfor PR/push testing.github/workflows/publish.ymlto use pinned Bun versioncontinue-on-errorhack from publish workflowRelated Issues
🤖 Generated with Claude Code