Separate out connect options from query options #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Picking this up now for 0.4.0. It will also clarify the situation described in #437. |
sodabrew
force-pushed
the
connect_options
branch
from
7bc82ab to
514c34b
Compare
| @@ -1,71 +1,69 @@ | |||
| module Mysql2 | |||
| class Client | |||
| attr_reader :query_options, :read_timeout | |||
| attr_reader :connect_optins, :query_options, :read_timeout | |||
sodabrew
force-pushed
the
connect_options
branch
3 times, most recently
from
be8a727 to
61d7088
Compare
sodabrew
changed the title
sodabrew
force-pushed
the
connect_options
branch
from
61d7088 to
2f48f3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea to resolve the confusing situation seen in #493 and a few previous tickets.
First pass code has the bad effect of overriding the user's settings with defaults if the user changes the class hash values in
@@default_query_optionsbefore connecting, but has not updated to know about@@default_connect_optionsintroduced here.Retains the bad situation of having both sets of options in the
@query_optionshash from there on out.Needs some more thinking, putting this out for comment and ideas.