Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancellation token support #10

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Add cancellation token support #10

merged 3 commits into from
Jan 22, 2025

Conversation

L-Sypniewski
Copy link
Contributor

@L-Sypniewski L-Sypniewski commented Jan 19, 2025 •
edited
Loading

This PR simply adds CancellationToken support to the methods in INpgmqClient and NpgmqCommandFactory

brianpursley
brianpursley reviewed Jan 22, 2025
View reviewed changes
Npgmq/NpgmqClient.cs Outdated Show resolved Hide resolved
@brianpursley
Copy link
Owner

The changes look good. I fixed a minor dotnet format issue related to the usings order and committed it so the build could proceed.

Tests are failing in the build action, but they pass locally for me. I need to see what the issue is... 👀

brianpursley
brianpursley reviewed Jan 22, 2025
View reviewed changes
Npgmq/NpgmqClient.cs Outdated Show resolved Hide resolved
@brianpursley brianpursley merged commit 49804ad into brianpursley:main Jan 22, 2025
@brianpursley
Copy link
Owner

Thanks @L-Sypniewski

This change was tagged and deployed as Npgmq 1.5.0 on nuget.

@L-Sypniewski L-Sypniewski deleted the support-cancellation-tokens branch January 23, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley brianpursley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-Sypniewski @brianpursley