frameworks - removed react and simplified vue framework section

brianvoe · Aug 2, 2024 · 45439ef · 45439ef
1 parent b3493ff
commit 45439ef
Show file tree

Hide file tree

Showing 39 changed files with 18 additions and 7,337 deletions.
diff --git a/.npmignore b/.npmignore
@@ -1,6 +1,4 @@
 node_modules/
-src/vue/node_modules/
-src/react/node_modules/
 .vscode/
 .github/
 

diff --git a/docs/index.html b/docs/index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html lang="en">
   <head>
     <meta charset="UTF-8" />
@@ -10,7 +10,7 @@
     <meta property="og:title" content="Slim Select" />
     <meta property="og:description" content="Advanced select dropdown" />
     <script type="module" crossorigin src="/assets/index.js"></script>
-    <link rel="stylesheet" crossorigin href="/assets/index.css">
+    <link rel="stylesheet" crossorigin href="/assets/index.css" />
   </head>
   <body>
     <noscript>
@@ -21,8 +21,6 @@
     </noscript>
     <div id="app"></div>
 
-    <!-- Adding React for Framework Preview -->
-
     <!-- Google tag (gtag.js) -->
     <script async src="https://www.googletagmanager.com/gtag/js?id=G-14PMXQVXTC"></script>
     <script>

diff --git a/index.html b/index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html lang="en">
   <head>
     <meta charset="UTF-8" />
@@ -20,9 +20,6 @@
     <div id="app"></div>
     <script type="module" src="/src/docs/main.ts"></script>
 
-    <!-- Adding React for Framework Preview -->
-    <script type="module" src="/src/react/src/frameworkpage.tsx"></script>
-
     <!-- Google tag (gtag.js) -->
     <script async src="https://www.googletagmanager.com/gtag/js?id=G-14PMXQVXTC"></script>
     <script>

diff --git a/package.json b/package.json
@@ -26,9 +26,6 @@
     },
     "./styles": "./dist/slimselect.css"
   },
-  "workspaces": [
-    "src/vue"
-  ],
   "repository": {
     "type": "git",
     "url": "git+https://github.com/brianvoe/slim-select.git"
@@ -43,13 +40,12 @@
   "scripts": {
     "dev": "vite --port=1111",
     "format": "prettier --write --cache --parser typescript \"src/**/*.ts\"",
-    "build": "npm run build:clean && npm run build:docs && npm run build:library && npm run build:frameworks",
+    "build": "npm run build:clean && npm run build:docs && npm run build:library",
     "build:clean": "rimraf ./dist/*",
     "build:docs": "vite build",
     "build:library": "npm run build:library:js && npm run build:library:css",
     "build:library:js": "cd src/slim-select && rollup --config ./rollup.config.mjs && cd ../../",
     "build:library:css": "cd src/slim-select && sass ./slimselect.scss ../../dist/slimselect.css --style=compressed && cd ../../",
-    "build:frameworks": "npm run build --workspaces",
     "test": "jest",
     "test:coverage": "jest --coverage"
   },
@@ -63,32 +59,23 @@
     "@rollup/plugin-typescript": "^11.1.5",
     "@slim-select/vue": "workspace:src/vue",
     "@testing-library/jest-dom": "^6.1.6",
-    "@testing-library/react": "^14.0.0",
     "@testing-library/user-event": "^14.5.2",
     "@types/downloadjs": "^1.4.6",
     "@types/jest": "^29.5.11",
-    "@types/react": "^18.2.46",
-    "@types/react-dom": "^18.2.18",
     "@typescript-eslint/eslint-plugin": "^6.17.0",
     "@typescript-eslint/parser": "^6.17.0",
-    "@vitejs/plugin-react": "^4.2.1",
     "@vitejs/plugin-vue": "^5.0.2",
     "clipboard": "^2.0.11",
     "downloadjs": "^1.4.7",
     "eslint": "^8.56.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-prettier": "^5.1.2",
-    "eslint-plugin-react": "^7.32.2",
-    "eslint-plugin-react-hooks": "^4.6.0",
-    "eslint-plugin-react-refresh": "^0.4.5",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "jest-canvas-mock": "^2.5.0",
     "jest-environment-jsdom": "^29.7.0",
     "prettier": "^3.1.1",
     "prismjs": "^1.29.0",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0",
     "rimraf": "^5.0.5",
     "rollup": "^4.9.2",
     "rollup-plugin-peer-deps-external": "^2.2.4",

diff --git a/src/docs/app.vue b/src/docs/app.vue
@@ -125,7 +125,6 @@ export default defineComponent({
           closable: 'close',
           options: [
             { text: 'vue', value: 'vue' },
-            { text: 'react', value: 'react' },
           ],
         },
       ] as DataArray,

diff --git a/src/docs/pages/frameworks/react.vue b/src/docs/pages/frameworks/react.vue
diff --git a/src/docs/pages/frameworks/vue.vue b/src/docs/pages/frameworks/vue.vue
@@ -1,14 +1,9 @@
 <script lang="ts">
-import { defineComponent, ref } from 'vue'
-
-// We need to import from the root of the package
-// Because if we use @slim-select/vue then we loose
-// hot reloading of the file changes
-import SlimSelectJS from '../../../slim-select'
-import SlimSelect from '../../../vue/slimselect.vue'
+import { defineComponent } from 'vue'
+import SlimSelectJS, { Events } from '../../../slim-select'
 import Settings from '../../../slim-select/settings'
 import { Option, OptionOptional } from '../../../slim-select/store'
-import { Events } from '../../../slim-select'
+import SlimSelect from '../../../slim-select/vue.vue'
 
 export default defineComponent({
   name: 'Vue',
@@ -86,14 +81,11 @@ export default defineComponent({
 
     <h3>Install</h3>
     <p>
-      The vue component is in a sub package under SlimSelect. All functionality still work in the implementation. I have
-      also added a v-model bind capability to it as well.
+      Slim Select doesnt have a package to import(anymore) due to its requirements of maintianing it within the repository. 
+      But we have provided a set of code you can add to your own project to get it working.
     </p>
-    <pre>
-      <code class="language-bash">
-        npm install @slim-select/vue
-      </code>
-    </pre>
+    <a href="https://github.com/slim-select/tree/master/src/slim-select/vue.vue">Download Component Here</a>
+    <br />
     <br />
 
     <h3>Simple example</h3>
@@ -122,7 +114,7 @@ export default defineComponent({
     <pre>
       <code class="language-javascript">
         import { defineComponent } from 'vue'
-        import SlimSelect from '@slim-select/vue'
+        import SlimSelect from '../your/path/to/slim-select/vue.vue'
 
         export default defineComponent({
           components: {
@@ -181,7 +173,7 @@ export default defineComponent({
     <pre>
       <code class="language-javascript">
         import { defineComponent } from 'vue'
-        import SlimSelect from '@slim-select/vue'
+        import SlimSelect from '../your/path/to/slim-select/vue.vue'
 
         export default defineComponent({
           components: {
@@ -236,7 +228,7 @@ export default defineComponent({
     <pre>
       <code class="language-javascript">
         import { defineComponent } from 'vue'
-        import SlimSelect from '@slim-select/vue'
+        import SlimSelect from '../your/path/to/slim-select/vue.vue'
 
         export default defineComponent({
           components: {
@@ -291,7 +283,7 @@ export default defineComponent({
     <pre>
       <code class="language-javascript">
         import { defineComponent } from 'vue'
-        import SlimSelect from '@slim-select/vue'
+        import SlimSelect from '../your/path/to/slim-select/vue.vue'
 
         export default defineComponent({
           components: {

diff --git a/src/docs/router.ts b/src/docs/router.ts
@@ -43,12 +43,7 @@ const router = createRouter({
       path: '/vue',
       name: 'Vue',
       component: () => import('./pages/frameworks/vue.vue'),
-    },
-    {
-      path: '/react',
-      name: 'React',
-      component: () => import('./pages/frameworks/react.vue'),
-    },
+    }
   ],
 })
 

diff --git a/src/react/.eslintignore b/src/react/.eslintignore
diff --git a/src/react/.eslintrc.cjs b/src/react/.eslintrc.cjs
diff --git a/src/react/.gitignore b/src/react/.gitignore
diff --git a/src/react/index.html b/src/react/index.html
diff --git a/src/react/jestconfig.json b/src/react/jestconfig.json
diff --git a/src/react/package.json b/src/react/package.json