Skip to content

fix(helm): Check HELM_NAMESPACE env var in CKV_K8S_21 #7355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2025
Merged

fix(helm): Check HELM_NAMESPACE env var in CKV_K8S_21 #7355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c888cb
Check HELM_NAMESPACE env var in CKV_K8S_21
inbalavital Oct 23, 2025
9a579af
Add test
inbalavital Oct 29, 2025
efcb2ce
Remove HELM_NAMESPACE env var after test
inbalavital Oct 29, 2025
4a11253
Use mock patch
inbalavital Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions checkov/kubernetes/checks/resource/k8s/DefaultNamespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import os
from typing import Any

from checkov.common.models.enums import CheckCategories, CheckResult
Expand Down Expand Up @@ -37,6 +38,8 @@ def scan_spec_conf(self, conf: dict[str, Any]) -> CheckResult:
if metadata:
if "namespace" in metadata and metadata["namespace"] != "default":
return CheckResult.PASSED
if os.getenv('HELM_NAMESPACE') and os.getenv('HELM_NAMESPACE') != "default":
return CheckResult.PASSED

# If namespace not defined it is default -> Ignore default Service account and kubernetes service
if conf["kind"] == "ServiceAccount" and metadata["name"] == "default":
Expand Down
14 changes: 14 additions & 0 deletions tests/kubernetes/checks/test_DefaultNamespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import os
import unittest
from unittest import mock

from checkov.kubernetes.checks.resource.k8s.DefaultNamespace import check
from checkov.kubernetes.runner import Runner
Expand All @@ -21,6 +22,19 @@ def test_summary(self):
self.assertEqual(summary['skipped'], 0)
self.assertEqual(summary['parsing_errors'], 0)

@mock.patch.dict(os.environ, {"HELM_NAMESPACE": "non-default"})
def test_summary_with_env_var(self):
runner = Runner()
current_dir = os.path.dirname(os.path.realpath(__file__))
test_files_dir = current_dir + "/example_DefaultNamespace"
report = runner.run(root_folder=test_files_dir, runner_filter=RunnerFilter(checks=[check.id]))
summary = report.get_summary()

self.assertEqual(summary['passed'], 11)
self.assertEqual(summary['failed'], 0)
self.assertEqual(summary['skipped'], 0)
self.assertEqual(summary['parsing_errors'], 0)


if __name__ == '__main__':
unittest.main()
Loading