-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub packages reference #214
Changes from 27 commits
7d7b6d9
fcaaae1
c7824a2
43646f8
b4d398f
495201d
2957fc3
c5e2290
39c92bc
fa047ba
3212de8
d712136
b7d3f75
ebb368e
d4452b7
8934d62
1d81342
fdf8310
2546d3f
2f70b7c
c45a6e9
e3dd042
f18ec60
3d7f642
6bcf990
6327c6d
7a4cb62
600f268
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jq
is another example likeopenssl
where the URL here is a release download rather than a git archive, and one published by the jq project. Trying outbrioche build -p packages/jq
here fails because the upstream source doesn't have./configure
while the original tarfile does, so I think it'd be better to revert this one(Longer term, it might be better to always use the autoconf build instead of the pre-packaged
./configure
, but that's a different conversation IMO and shouldn't be in scope for this PR)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it quite strange that most of the release downloads contain the script
./configure
whereas the git archive does not. I thought we always needed to generate the./configure
through tools asautoreconf
. Let's leverage for now the possibility to use the pre-built one that comes with the release download. Indeed it makes things much easier for now.