Add libffi package
#215
Merged
Add libffi package
#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new package for libffi, a library for FFI (foreign function interface) calls.
The main motivation here was to include support for Python, so I went ahead and updated Python. This was as simple as adding libffi as a dependency during the Python build-- the
configurescript auto-detects it. I also updated the Python build to link in a few extra native libraries. I noticed these libraries were required while working on packaging AWS CLI (which uses libffi), and these all seemed like common, low-level libraries, so I thought it made sense to add them to Python by default.Later, we should probably work backwards and figure out where these libraries are being used, and figure out if we can auto-detect them too.