Standardize version string handling by replacing 'v' prefix in auto update #226
Conversation
…g 'v' prefix Signed-off-by: Jérémy Audiger <[email protected]>
jaudiger
force-pushed
the
refactor-auto-update
branch
from
ed19f14 to
1a05b5a
Compare
| @@ -51,7 +51,7 @@ export function autoUpdate() { | |||
|
|
|||
| let version = $releaseData | |||
| | get tag_name | |||
| | str replace '^v' '' | |||
| | str replace --regex '^v' '' | |||
There was a problem hiding this comment.
@asheliahut I had to adjust the argument here to properly use the regex capabilities of str replace. Otherwise it was just doing a raw find and replace.
There was a problem hiding this comment.
I wonder if there is a way to take this stuff for GitHub and make it generic so we put in the repo name, and get back this part of this and a path for any replacement for things in version.
There was a problem hiding this comment.
@kylewlacy began to expose possible solutions here: #176 to hide this work into a dedicated function that could be static or not (depending of the option chosen).
There was a problem hiding this comment.
Awesome, Yeah I am not saying this needs to be done here. I am good with accepting. Sorry I have been really focused on work lately.
There was a problem hiding this comment.
Don't worry, same on my side, I'm juggling with my work too.
|
Makes sense to me to merge as-is! |
Per discussion #225 (comment)