[WOR-850] Delete billing profile during billing project deletion (GCP) #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahrens
commented
Jan 29, 2024
| Future.successful() | ||
| case (None, false) => | ||
| logger.info( | ||
| s"Deleting billing project $projectName, but no associated billing profile record to delete (could be a legacy project)" |
There was a problem hiding this comment.
Once we have backfilled billing profiles for existing GCP billing projects, we can get rid of this case.
cahrens
commented
Jan 29, 2024
| @@ -184,10 +184,10 @@ class BillingProjectOrchestrator(ctx: RawlsRequestContext, | |||
| ) | |||
| ) | |||
| } | |||
| billingProfileId <- billingRepository.getBillingProfileId(projectName) | |||
| projectLifecycle = billingProfileId match { | |||
| azureManagedAppCoordinates <- billingRepository.getAzureManagedAppCoordinates(projectName) | |||
There was a problem hiding this comment.
Needed to change how we decide if the billing project is an Azure one. Note that we don't store a cloudPlatform.
cahrens
requested review from
a team,
blakery and
okotsopoulos
and removed request for
a team
blakery
approved these changes
Jan 29, 2024
okotsopoulos
approved these changes
Jan 29, 2024
marctalbott
added a commit
that referenced
this pull request
Feb 23, 2024
…g projects. (#2698) * Create profile model for GCP projects. * rename * Refactoring * Try removing the prefix * Test removal of prefix. * Store the billing profile ID in the billing project. * Split tests, mock repo. * Code review feedback. * [WOR-850] Delete billing profile during billing project deletion (GCP) (#2715) * [WOR-852] Update billing profile when updating billing account (#2736) * add missing implicits to pact tests * add null values to expected createProfile request * specify GCP as billing project's cloud platform after updating billing account --------- Co-authored-by: Marcus Talbott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/WOR-850
This PR adds the code for GCP billing project deletion to also delete the associated billing profile, if it exists. Note that this is against a feature branch (which creates the billing profile during GCP billing project creation).
Tested running Rawls locally to create and delete GCP billing projects.