WOR-1480 use open telemetry to emit metrics #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoet
commented
Jan 30, 2024
| (Slash ~ "api").? / "workspaces" / (!"entities" ~ Segment) / (Segment ~ SegmentIgnore.repeat(0, | ||
| Int.MaxValue, | ||
| separator = Slash | ||
| (Slash ~ "api").? / "workspaces" / (!("entities" | "id") ~ Segment) / (Segment ~ SegmentIgnore.repeat(0, |
There was a problem hiding this comment.
this and the following change made me look for better and more future proof ways to figure out a standard name for an api "route". We have this all in swagger, why not parse that?
tlangs
approved these changes
Jan 30, 2024
|
jenkins retest |
dvoet
commented
Jan 31, 2024
| override def receive: Receive = { case DeleteExpiredGrants => | ||
| for { | ||
| _ <- openTelemetry.incrementCounter("fastpass-monitor-sweeper-start", tags = openTelemetryTags).unsafeToFuture() |
There was a problem hiding this comment.
note that I removed this metric because it has no value - this function is called on a schedule every 10s
aherbst-broad
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/WOR-1480
PR checklist
model/, then you should publish a new officialrawls-modeland updaterawls-modelin Orchestration's dependencies.