[WOR-1297] Continue workspace deletion if all apps/runtimes in are ERROR status #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahrens
requested review from
a team,
marctalbott,
aherbst-broad and
okotsopoulos
and removed request for
a team and
marctalbott
aherbst-broad
approved these changes
Feb 1, 2024
okotsopoulos
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/WOR-1297
If runtimes are apps are in an ERROR state, Leo will not be able to delete them. Go ahead and attempt to delete the workspace. I ran this past IA in https://broadinstitute.slack.com/archives/CA3NP1733/p1706723414160159.
I was not able to manually test this beyond ensuring that deleting of GCP workspaces succeeds in the usual happy cases… I don't have any Azure workspaces with apps or runtimes stuck in an ERROR state.