AJ-1540: local dev to mysql 8 #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
commented
Feb 7, 2024
| MYSQL_IMAGE=mysql/mysql-server | ||
| MYSQL_VERSION=5.7 | ||
| MYSQL_VERSION=8.0.32 |
There was a problem hiding this comment.
since we need to get Rawls off Jenkins by the end of April, this should be a relatively temporary state.
calypsomatic
reviewed
Feb 7, 2024
| it should "be testing against MySQL 5.7" in withEmptyTestDatabase { | ||
| // The docker version installed on DSP Jenkins does not like the "mysql" docker image, so we use "mysql/mysql-server" | ||
| // instead, which only has a 8.0.32 tag. See /docker/run-mysql.sh. | ||
| // TODO: Move to mysql:8.0.35 once we no longer depend on Jenkins. |
There was a problem hiding this comment.
Is this noted in the move-off-jenkins ticket?
There was a problem hiding this comment.
yes, it is! … now :)
yuliadub
approved these changes
Feb 7, 2024
calypsomatic
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: AJ-1540
run-mysql.shscript.run-mysql.shscript.Note that in your local dev environment, if you already have mysql running via ./docker/run-mysql.sh, you'll have to stop it and start it to get the upgrade.
PR checklist
model/, then you should publish a new officialrawls-modeland updaterawls-modelin Orchestration's dependencies.