Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ontology label for metadata validation tests (SCP-5953) #385

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

jlchang
Copy link
Collaborator

@jlchang jlchang commented Mar 12, 2025

Background

The official ontology label for HANCESTRO_0005 is now "European ancestry" rather than "European". This change caused several metadata validation tests to fail. Metadata validation inputs and reference validation results have been updated to reflect the new ontology label so that the broken tests will now pass.

Manual testing

To manually verify that the broken tests have been fixed, go to the tests directory of this repo and run:

pytest

@jlchang jlchang requested review from bistline and eweitz March 12, 2025 19:19
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.06%. Comparing base (9185c71) to head (aedbcf1).
Report is 6 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #385      +/-   ##
===============================================
+ Coverage        74.50%   76.06%   +1.55%     
===============================================
  Files               30       30              
  Lines             4491     4491              
===============================================
+ Hits              3346     3416      +70     
+ Misses            1145     1075      -70     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlchang jlchang changed the title Update ontology label for test inputs and refs (SCP-5953) Update ontology label for metadata validation tests (SCP-5953) Mar 12, 2025
Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the swift update!

@jlchang jlchang merged commit 0067ebd into development Mar 13, 2025
5 checks passed
@jlchang jlchang deleted the jlc_fix_validation_tests branch March 13, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants