-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to newest base image, Ruby 3.4 (SCP-5959) #2221
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #2221 +/- ##
===============================================
+ Coverage 70.51% 70.60% +0.08%
===============================================
Files 332 331 -1
Lines 28493 28290 -203
Branches 2518 2518
===============================================
- Hits 20092 19974 -118
+ Misses 8254 8169 -85
Partials 147 147
🚀 New features to boost your workflow:
|
There are likely some missing dependencies still, so this shouldn't merge until I can identify them. Also, I just realized another downside to scheduled instances - we can't run CI after hours. Not a big deal, but something to consider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review. Installed Ruby 3.4.2 and verified that my local instance works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I updated locally; more notes here.
BACKGROUND & CHANGES
This updates to
single-cell-portal/rails-baseimage:3.0.0
which includes the following updates:stdlib
Most importantly, this gets our Docker image current with the latest release in phusion/passenger-docker and allows us to update Ruby, Passenger and Nginx on a more regular basis.
MANUAL TESTING
This PR will run normal CI to confirm usage while running inside Docker, so testing for native local development is likely all that is required for reviewers. Since we rarely run local development inside Docker, it is not strictly necessary to test this, but instructions are included below should you wish to verify both.
For native local development:
ruby-build: definition not found: 3.4.2
, do as message instructs and runbrew upgrade ruby-build
rbenv
, this is done withrbenv install 3.4.2
- note this takes ~10 minrbenv shell 3.4.2
, or globally withrbenv global 3.4.2
bundle install
sassc
,bootstrap-sass
, orunf_ext
, you may need to reinstall both your Xcode command line tools and Ruby 3.4.2. This can be done by first requesting admin access and then running the following (this can take longer than 15 min to complete - if you admin session expires, the installation will continue):warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)
, you can disable these by rebooting your server and prependingRUBYOPT=--disable-frozen-string-literal
to therails s
command.To test inside Docker:
docker-compose
using the new-l
flag to denote the locally built image: