Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly identify bundled files in upload wizard (SCP-5941) #2222

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

bistline
Copy link
Contributor

BACKGROUND & CHANGES

This fixes a bug in the upload wizard where bundled sequence index files were not correctly identified. The parent files was instead being supplied to the index form as it was matching on the study_file_bundle_id first before finding the index file. Now, an added check to ignore the file by its ID allows the index to be found. This appears to have affect BAM files as well, but given their sparsity in SCP it wasn't identified until now due to the fragment BED file work.

MANUAL TEST

  1. Boot as normal and load the upload wizard for any study that has BED or BAM files
  2. Confirm the index file is correct for the parent sequence file

@bistline bistline requested review from eweitz and jlchang March 20, 2025 18:55
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.63%. Comparing base (734ccf9) to head (b06b7ef).
Report is 12 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2222      +/-   ##
===============================================
+ Coverage        70.51%   70.63%   +0.12%     
===============================================
  Files              332      331       -1     
  Lines            28493    28292     -201     
  Branches          2518     2464      -54     
===============================================
- Hits             20092    19985     -107     
+ Misses            8254     8160      -94     
  Partials           147      147              
Files with missing lines Coverage Δ
app/javascript/components/upload/upload-utils.js 91.21% <100.00%> (ø)
test/js/upload-wizard/file-info-responses.js 100.00% <100.00%> (ø)

... and 66 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jlchang jlchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review - Sequence file form now displays index file name as expected (thanks for figuring out my vite issue @bistline!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants