Skip to content

Conversation

@Spomky
Copy link

@Spomky Spomky commented Dec 4, 2025

This PR enables Symfony 8 dependencies.

Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like composer.lock needs an update too please

@asgrim asgrim added this to the 7.7.0 milestone Dec 5, 2025
@Spomky
Copy link
Author

Spomky commented Dec 5, 2025

Not sure why the composer.lock is present on a library but ok I will update it.

@asgrim
Copy link
Member

asgrim commented Dec 5, 2025

Thanks 👍

@Spomky
Copy link
Author

Spomky commented Dec 12, 2025

Done.
Let's run the test suites.

@asgrim asgrim self-requested a review December 12, 2025 14:43
@asgrim
Copy link
Member

asgrim commented Dec 12, 2025

Hmm; the composer update should be run with the widest compatible dependency set; typically php8.1 /usr/local/bin/composer update or similar should suffice.

Not sure why the composer.lock is present on a library

This allows us to develop and test against a fixed set of dependencies (usually the widest, as noted above), and CI can test all other permutations.

@Spomky
Copy link
Author

Spomky commented Dec 12, 2025

Failing tests (PHP8.1 to 8.3 locked) are because SF 8 require PHP 8.4+.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (7.7.x@df24aac). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             7.7.x     #808   +/-   ##
========================================
  Coverage         ?   36.74%           
  Complexity       ?      283           
========================================
  Files            ?       27           
  Lines            ?     1132           
  Branches         ?        0           
========================================
  Hits             ?      416           
  Misses           ?      716           
  Partials         ?        0           
Flag Coverage Δ
phpunit 36.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants