-
Notifications
You must be signed in to change notification settings - Fork 83
Update Symfony package versions to include 8.0.0 #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.7.x
Are you sure you want to change the base?
Conversation
asgrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like composer.lock needs an update too please
|
Not sure why the composer.lock is present on a library but ok I will update it. |
|
Thanks 👍 |
|
Done. |
|
Hmm; the composer update should be run with the widest compatible dependency set; typically
This allows us to develop and test against a fixed set of dependencies (usually the widest, as noted above), and CI can test all other permutations. |
|
Failing tests (PHP8.1 to 8.3 locked) are because SF 8 require PHP 8.4+. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 7.7.x #808 +/- ##
========================================
Coverage ? 36.74%
Complexity ? 283
========================================
Files ? 27
Lines ? 1132
Branches ? 0
========================================
Hits ? 416
Misses ? 716
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR enables Symfony 8 dependencies.