Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to #56 #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix to #56 #146

wants to merge 2 commits into from

Conversation

simonzack
Copy link

Add/remove is done by calling the constructor, which retains the caches so builds remain fast.

I took this approach, since from my reading of the code, reset() needs to be called somewhere first in the chokidar handler so the pipeline can be modified, since bundle() was called previously.

If there's a better way please let me know and I'll update the PR.

@zertosh
Copy link
Member

zertosh commented Mar 23, 2015

@simonzack The use case for this (according to #56) is for when you use watchify via the command-line. How about if in bin/cmd.js you handle the tearing down the previous watchify->browserify instance and spinning up a new one on add/unlink whatever?

@simonzack
Copy link
Author

@zertosh Well, my implementation keeps the cache. My own use case was for gulp, but you're right that this perhaps is only half the fix, as it doesn't yet address the cmd issue.

@zertosh zertosh mentioned this pull request Mar 25, 2015
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants