Skip to content

fix: use 127.0.0.1 as default hostname for HTTP server #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avital Ben-Natan (dewdad) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use 127.0.0.1 as default hostname for HTTP server #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/server/src/api/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
import type { Env, HttpServerConfig } from './types'
import { defaultCorsConfig } from './utils/cors'

async function assertPortAvailable(port: number): Promise<void> {
async function assertPortAvailable(port: number, host: string): Promise<void> {
const net = await import('node:net')
return new Promise((resolve, reject) => {
const probe = net.createServer()
Expand All @@ -52,7 +52,7 @@ async function assertPortAvailable(port: number): Promise<void> {
}
})

probe.listen({ port, host: '127.0.0.1', exclusive: true }, () => {
probe.listen({ port, host, exclusive: true }, () => {
probe.close(() => resolve())
})
})
Expand All @@ -61,7 +61,7 @@ async function assertPortAvailable(port: number): Promise<void> {
export async function createHttpServer(config: HttpServerConfig) {
const {
port,
host = '0.0.0.0',
host = '127.0.0.1',
browserosId,
executionDir,
resourcesDir,
Expand Down Expand Up @@ -183,7 +183,7 @@ export async function createHttpServer(config: HttpServerConfig) {
)
})

await assertPortAvailable(port)
await assertPortAvailable(port, host)

const server = Bun.serve({
fetch: (request, server) => app.fetch(request, { server }),
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class Application {
try {
await createHttpServer({
port: this.config.serverPort,
host: '0.0.0.0',
host: this.config.mcpAllowRemote ? '0.0.0.0' : '127.0.0.1',
version: VERSION,
browser,
controller,
Expand Down
Loading