-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: restore server version flag #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3f28378
fix: guard compiled server native addon loading
shadowfax92 b65def9
fix: stop embedding bun runtime argv in server binary
shadowfax92 c99e9b6
test: assert bare server version flag
shadowfax92 09f280e
chore: register compiled server entrypoint
shadowfax92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/browseros-agent/apps/server/src/compiled-bootstrap.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { installNativeAddonGuard } from './lib/native-addon-guard' | ||
|
|
||
| installNativeAddonGuard() | ||
| await import('./index') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/browseros-agent/apps/server/src/lib/native-addon-guard.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| const NATIVE_ADDON_DISABLED_MESSAGE = | ||
| 'BrowserOS server disables native addon loading in compiled production builds' | ||
|
|
||
| interface GuardedProcess extends NodeJS.Process { | ||
| __browserosNativeAddonGuardInstalled?: boolean | ||
| } | ||
|
|
||
| /** Blocks native addons before Bun can extract bundled `.node` files. */ | ||
| export function installNativeAddonGuard(): void { | ||
| const guardedProcess = process as GuardedProcess | ||
| if (guardedProcess.__browserosNativeAddonGuardInstalled) return | ||
|
|
||
| const guard: NodeJS.Process['dlopen'] = () => { | ||
| throw new Error(NATIVE_ADDON_DISABLED_MESSAGE) | ||
| } | ||
|
|
||
| process.dlopen = guard | ||
| guardedProcess.__browserosNativeAddonGuardInstalled = true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import.meta.diroverprocess.cwd()so the path resolves correctly regardless of which working directory the test runner is launched from. Ifbun testis invoked from the repo root,process.cwd()won't point topackages/browseros-agentand every subprocess-spawning test in this file will fail with a module-not-found error.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!