Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Bring in Credentials Leakage Fix #88

Merged
merged 1 commit into from
May 31, 2019
Merged

Bring in Credentials Leakage Fix #88

merged 1 commit into from
May 31, 2019

Conversation

ericbeland
Copy link
Contributor

This is a port of the BrowserMob PR here:

lightbody/browsermob-proxy#756

@aliowka Have I captured your logic? getUri was deprecated.

Copy link
Contributor

@dpowell dpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have test coverage for this, but the change itself looks sound.

@ericbeland ericbeland merged commit db9abcc into master May 31, 2019
@ericbeland ericbeland deleted the fix-creds-leak branch June 16, 2019 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants