Skip to content

Tests: Adjust software tests for CrateDB #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Tests: Adjust software tests for CrateDB #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
830dc88
Tests: Adjust software tests for CrateDB
amotl Jul 5, 2025
8be6720
Tests: Fixups for CrateDB
amotl Jul 5, 2025
c49740f
Tests: Improve resource teardown by closing/disposing connections etc.
amotl Jul 6, 2025
f968356
Tests: Activate CrateDB
amotl Jul 6, 2025
c239e4f
CI: The CrateDB Testcontainer does not support `xdist` yet
amotl Jul 6, 2025
afbd13c
Tests: Add CrateDBDestinationTest
amotl Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ concurrency:

jobs:
tests:
name: "Regular, Python ${{ matrix.python-version }}"
strategy:
matrix:
# I tried running stuff on macOS but it was too slow and unreliable.
Expand Down Expand Up @@ -64,3 +65,22 @@ jobs:
run: make test-ci
- name: check the formatting
run: make lint-ci

tests-cratedb:
name: "CrateDB"
runs-on: ubuntu-latest
steps:
- name: Acquire sources
uses: actions/checkout@v4
- name: Install Microsoft ODBC
run: sudo ACCEPT_EULA=Y apt-get install msodbcsql18 -y
- name: Install Python
uses: actions/setup-python@v5
with:
python-version: 3.12
- name: Install uv
uses: astral-sh/setup-uv@v6
- name: Install project
run: make deps-ci
- name: Run tests
run: make test-ci-cratedb
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ deps-ci:
uv pip install --system -r requirements-dev.txt

test-ci:
set -a; source test.env; set +a; TESTCONTAINERS_RYUK_DISABLED=true pytest -n auto -x -rP -vv --tb=short --durations=10 --cov=ingestr --no-cov-on-fail
set -a; source test.env; set +a; TESTCONTAINERS_RYUK_DISABLED=true pytest -n auto -x -rP -vv --tb=short --durations=10 --cov=ingestr --no-cov-on-fail -k "not cratedb"

test-ci-cratedb:
set -a; source test.env; set +a; TESTCONTAINERS_RYUK_DISABLED=true pytest -rP -vv --tb=short --durations=10 --cov=ingestr --no-cov-on-fail -k "cratedb"

test : venv lock-deps
. venv/bin/activate; $(MAKE) test-ci
Expand Down
Loading