Skip to content

Naming things: Rename _kafka_msg_id to _kafka__msg_id #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Naming things: Rename _kafka_msg_id to _kafka__msg_id #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ingestr/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ def get_output_table():
dest_engine = sqlalchemy.create_engine(dest_uri)
with dest_engine.connect() as conn:
res = conn.execute(
"select _kafka__data from testschema.output order by _kafka_msg_id asc"
"select _kafka__data from testschema.output order by _kafka__msg_id asc"
).fetchall()
dest_engine.dispose()
return res
Expand Down
2 changes: 1 addition & 1 deletion ingestr/src/kafka/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def default_msg_processor(msg: Message) -> Dict[str, Any]:
},
"data": msg.value().decode("utf-8"),
},
"_kafka_msg_id": digest128(topic + str(partition) + str(key)),
"_kafka__msg_id": digest128(topic + str(partition) + str(key)),
}


Expand Down