Code

Refactor NN code#111

Code

Merged

michelole merged 16 commits intobst-mug:masterbst-mug/n2c2:masterfrom michelole:cleanupmichelole/n2c2:cleanupCopy head branch name to clipboardJun 4, 2019

+993-1,066

Commits

Commits on May 29, 2019

• Move NN iterators into own package

  michelole

  committed
  5cc6602

  Copy full SHA for 5cc6602

Commits on Jun 3, 2019

• Refactor code around new interface InputRepresentation

  Show description for d524666
  michelole

  committed
  d524666

  Copy full SHA for d524666

• Rename iterators and classifiers for better readability

  michelole

  committed
  65ba2a4

  Copy full SHA for 65ba2a4

• Extract architecture code into own interface

  Show description for 2bc8a92
  michelole

  committed
  2bc8a92

  Copy full SHA for 2bc8a92

• Pull-up saveAndLoad test method

  Show description for 94f1b42
  michelole

  committed
  94f1b42

  Copy full SHA for 94f1b42

• DRY loadFeaturesForNarrative

  Show description for 6ee98d9
  michelole

  committed
  6ee98d9

  Copy full SHA for 6ee98d9

• Use f ordering for tensors

  Show description for af562fd
  michelole

  committed
  af562fd

  Copy full SHA for af562fd

Commits on Jun 4, 2019

• DRY Use getUnits wherever possible

  michelole

  committed
  623f97c

  Copy full SHA for 623f97c

• Use Math.max where possible

  michelole

  committed
  0436427

  Copy full SHA for 0436427

• Make getNext code paths consistent

  michelole

  committed
  23eb491

  Copy full SHA for 23eb491

• Pull up getNext method

  michelole

  committed
  2d5121f

  Copy full SHA for 2d5121f

• DRY getLongestSequenceSize method

  Show description for 1dcc61b
  michelole

  committed
  1dcc61b

  Copy full SHA for 1dcc61b

• Refactor fillBinaryMultiHotVector as a pure method

  michelole

  committed
  f2999ce

  Copy full SHA for f2999ce

• Refactor fillBinaryMultiHotVector as a pure method

  michelole

  committed
  bd1ab8c

  Copy full SHA for bd1ab8c

• Remove unused attributes and document empty methods

  michelole

  committed
  5d707fa

  Copy full SHA for 5d707fa

• Remove unnecessary comparison

  michelole

  committed
  f075134

  Copy full SHA for f075134