Skip to content

chore: ignore local .mcp.json MCP server config - #1680

Open
ordishs wants to merge 1 commit into
bsv-blockchain:mainfrom
ordishs:chore/gitignore-mcp-json
Open

chore: ignore local .mcp.json MCP server config#1680
ordishs wants to merge 1 commit into
bsv-blockchain:mainfrom
ordishs:chore/gitignore-mcp-json

Conversation

@ordishs

@ordishs ordishs commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

A .mcp.json in the repo root holds per-developer MCP server endpoints, internal hostnames among them. It is not shared configuration and it is not tracked, so it shows up as an untracked file in every working tree that has one. Ignore it.

No behaviour change; one line in .gitignore.

Verified: git check-ignore -v .mcp.json matches at .gitignore:124, and a real .mcp.json placed in the tree no longer appears in git status.

@ordishs
chore: ignore local .mcp.json MCP server config
6f3498d 
.mcp.json holds per-developer MCP server endpoints (internal hostnames among
them) and is not shared configuration. Keep it out of the tree.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🤖 Claude Code Review

Status: Complete

Current Review:

  • No issues found. This adds a single .mcp.json entry to .gitignore (line 124).
  • Change is correct and safe: no .mcp.json is currently tracked, so no git rm --cached is required. The pattern has no slash, so it correctly ignores .mcp.json at the repo root and in any subdirectory.
  • The PR body verification (git check-ignore -v .mcp.json matching at .gitignore:124) is accurate. No behaviour change, no docs impacted.

@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Benchmark Comparison Report

Baseline: main (unknown)

Current: PR-1680 (ac201f2)

Summary

  • Regressions: 0
  • Improvements: 0
  • Unchanged: 139
  • Significance level: p < 0.05
All benchmark results (sec/op)
Benchmark Baseline Current Change p-value
_NewBlockFromBytes-4 1.738µ 1.721µ ~ 0.400
Block_ValidOrderAndBlessed_DiskVsMemory/leaves=1024/memory-4 12.40m 12.63m ~ 0.100
Block_ValidOrderAndBlessed_DiskVsMemory/leaves=1024/disk_1-4 12.91m 12.89m ~ 1.000
Block_ValidOrderAndBlessed_DiskVsMemory/leaves=1024/disk_2-4 12.92m 12.91m ~ 0.200
Block_ValidOrderAndBlessed_DiskVsMemory/leaves=16384/memo... 30.14m 29.92m ~ 1.000
Block_ValidOrderAndBlessed_DiskVsMemory/leaves=16384/disk... 39.74m 38.38m ~ 0.400
Block_ValidOrderAndBlessed_DiskVsMemory/leaves=16384/disk... 39.59m 38.62m ~ 0.400
SplitSyncedParentMap_SetIfNotExists/256_buckets-4 64.12n 64.06n ~ 0.700
SplitSyncedParentMap_SetIfNotExists/16_buckets-4 63.99n 63.86n ~ 0.100
SplitSyncedParentMap_SetIfNotExists/1_bucket-4 64.17n 64.08n ~ 1.000
SplitSyncedParentMap_ConcurrentSetIfNotExists/256_buckets... 30.12n 30.98n ~ 0.600
SplitSyncedParentMap_ConcurrentSetIfNotExists/16_buckets_... 51.81n 52.87n ~ 0.700
SplitSyncedParentMap_ConcurrentSetIfNotExists/1_bucket_pa... 106.2n 113.8n ~ 0.100
MiningCandidate_Stringify_Short-4 225.2n 223.2n ~ 0.200
MiningCandidate_Stringify_Long-4 1.567µ 1.543µ ~ 0.100
MiningSolution_Stringify-4 780.8n 783.0n ~ 0.200
BlockInfo_MarshalJSON-4 1.588µ 1.588µ ~ 1.000
NewFromBytes-4 157.7n 158.3n ~ 0.700
AddTxBatchColumnar_Validation-4 2.044µ 2.054µ ~ 1.000
OffsetValidationLoop-4 641.0n 648.8n ~ 1.000
Mine_EasyDifficulty-4 60.77µ 60.80µ ~ 1.000
Mine_WithAddress-4 6.994µ 7.648µ ~ 0.100
BlockAssembler_AddTx-4 0.02704n 0.02747n ~ 1.000
AddNode-4 10.57 10.89 ~ 0.200
AddNodeWithMap-4 10.42 10.78 ~ 1.000
DirectSubtreeAdd/4_per_subtree-4 61.88n 58.52n ~ 0.100
DirectSubtreeAdd/64_per_subtree-4 30.21n 30.22n ~ 1.000
DirectSubtreeAdd/256_per_subtree-4 28.92n 29.26n ~ 0.400
DirectSubtreeAdd/1024_per_subtree-4 27.88n 28.02n ~ 0.100
DirectSubtreeAdd/2048_per_subtree-4 27.54n 27.71n ~ 0.600
SubtreeProcessorAdd/4_per_subtree-4 238.0n 241.4n ~ 0.400
SubtreeProcessorAdd/64_per_subtree-4 234.8n 240.4n ~ 0.100
SubtreeProcessorAdd/256_per_subtree-4 233.7n 237.8n ~ 0.700
SubtreeProcessorAdd/1024_per_subtree-4 228.2n 230.5n ~ 0.100
SubtreeProcessorAdd/2048_per_subtree-4 229.3n 229.8n ~ 0.700
SubtreeProcessorRotate/4_per_subtree-4 232.6n 232.0n ~ 0.900
SubtreeProcessorRotate/64_per_subtree-4 230.9n 230.7n ~ 1.000
SubtreeProcessorRotate/256_per_subtree-4 232.1n 231.8n ~ 0.300
SubtreeProcessorRotate/1024_per_subtree-4 231.1n 232.3n ~ 1.000
SubtreeNodeAddOnly/4_per_subtree-4 54.79n 55.50n ~ 0.400
SubtreeNodeAddOnly/64_per_subtree-4 34.14n 34.26n ~ 0.100
SubtreeNodeAddOnly/256_per_subtree-4 33.23n 33.28n ~ 0.100
SubtreeNodeAddOnly/1024_per_subtree-4 32.52n 32.67n ~ 1.000
SubtreeCreationOnly/4_per_subtree-4 117.1n 139.7n ~ 0.100
SubtreeCreationOnly/64_per_subtree-4 396.5n 391.2n ~ 0.700
SubtreeCreationOnly/256_per_subtree-4 1.289µ 1.269µ ~ 0.300
SubtreeCreationOnly/1024_per_subtree-4 4.280µ 4.801µ ~ 0.100
SubtreeCreationOnly/2048_per_subtree-4 7.566µ 8.441µ ~ 0.100
SubtreeProcessorOverheadBreakdown/64_per_subtree-4 230.2n 233.3n ~ 0.100
SubtreeProcessorOverheadBreakdown/1024_per_subtree-4 229.4n 233.2n ~ 0.100
ParallelGetAndSetIfNotExists/1k_nodes-4 10.18m 12.20m ~ 0.100
ParallelGetAndSetIfNotExists/10k_nodes-4 13.43m 15.68m ~ 0.100
ParallelGetAndSetIfNotExists/50k_nodes-4 16.26m 19.51m ~ 0.100
ParallelGetAndSetIfNotExists/100k_nodes-4 19.45m 18.23m ~ 0.100
SequentialGetAndSetIfNotExists/1k_nodes-4 9.203m 12.689m ~ 0.100
SequentialGetAndSetIfNotExists/10k_nodes-4 13.33m 17.60m ~ 0.100
SequentialGetAndSetIfNotExists/50k_nodes-4 20.49m 22.93m ~ 0.100
SequentialGetAndSetIfNotExists/100k_nodes-4 27.89m 29.96m ~ 0.100
ProcessOwnBlockSubtreeNodesParallel/1k_nodes-4 12.61m 12.34m ~ 1.000
ProcessOwnBlockSubtreeNodesParallel/10k_nodes-4 13.96m 14.49m ~ 0.100
ProcessOwnBlockSubtreeNodesParallel/100k_nodes-4 18.75m 19.31m ~ 0.100
ProcessOwnBlockSubtreeNodesSequential/1k_nodes-4 13.35m 15.03m ~ 1.000
ProcessOwnBlockSubtreeNodesSequential/10k_nodes-4 14.85m 15.76m ~ 0.700
ProcessOwnBlockSubtreeNodesSequential/100k_nodes-4 52.57m 51.73m ~ 0.200
DiskTxMap_SetIfNotExists-4 3.500µ 3.482µ ~ 0.200
DiskTxMap_SetIfNotExists_Parallel-4 3.383µ 3.255µ ~ 0.200
DiskTxMap_ExistenceOnly-4 310.1n 313.5n ~ 1.000
Queue-4 187.7n 188.7n ~ 0.300
AtomicPointer-4 4.306n 4.450n ~ 0.700
TxMapSetIfNotExists-4 62.72n 63.33n ~ 0.700
TxMapSetIfNotExistsDuplicate-4 47.44n 47.36n ~ 1.000
ChannelSendReceive-4 587.0n 583.8n ~ 0.700
CalcBlockWork-4 518.5n 523.4n ~ 0.400
CalculateWork-4 701.9n 703.2n ~ 1.000
CheckOldBlockIDs/on-chain-prefetch/1000-4 70.87µ 68.43µ ~ 1.000
CheckOldBlockIDs/in-memory-chain-check/1000-4 1.376m 1.374m ~ 1.000
CheckOldBlockIDs/on-chain-prefetch/10000-4 455.1µ 474.9µ ~ 0.100
CheckOldBlockIDs/in-memory-chain-check/10000-4 2.094m 2.112m ~ 1.000
BuildBlockLocatorString_Helpers/Size_10-4 1.346µ 1.481µ ~ 0.100
BuildBlockLocatorString_Helpers/Size_100-4 12.86µ 14.07µ ~ 0.100
BuildBlockLocatorString_Helpers/Size_1000-4 128.4µ 134.8µ ~ 0.100
CatchupWithHeaderCache-4 106.7m 106.7m ~ 1.000
SubtreeSizes/10k_tx_4_per_subtree-4 1.420m 1.419m ~ 1.000
SubtreeSizes/10k_tx_16_per_subtree-4 329.2µ 333.1µ ~ 0.400
SubtreeSizes/10k_tx_64_per_subtree-4 78.99µ 78.54µ ~ 0.700
SubtreeSizes/10k_tx_256_per_subtree-4 19.48µ 19.54µ ~ 1.000
SubtreeSizes/10k_tx_512_per_subtree-4 9.605µ 9.696µ ~ 0.400
SubtreeSizes/10k_tx_1024_per_subtree-4 4.800µ 4.855µ ~ 0.700
SubtreeSizes/10k_tx_2k_per_subtree-4 2.381µ 2.410µ ~ 0.100
BlockSizeScaling/10k_tx_64_per_subtree-4 76.49µ 76.82µ ~ 0.700
BlockSizeScaling/10k_tx_256_per_subtree-4 19.27µ 19.18µ ~ 0.200
BlockSizeScaling/10k_tx_1024_per_subtree-4 4.757µ 4.769µ ~ 0.700
BlockSizeScaling/50k_tx_64_per_subtree-4 400.8µ 407.7µ ~ 0.700
BlockSizeScaling/50k_tx_256_per_subtree-4 95.34µ 96.70µ ~ 0.400
BlockSizeScaling/50k_tx_1024_per_subtree-4 23.61µ 23.61µ ~ 1.000
SubtreeAllocations/small_subtrees_exists_check-4 165.4µ 164.3µ ~ 1.000
SubtreeAllocations/small_subtrees_data_fetch-4 166.4µ 167.4µ ~ 1.000
SubtreeAllocations/small_subtrees_full_validation-4 330.6µ 336.2µ ~ 0.100
SubtreeAllocations/medium_subtrees_exists_check-4 9.600µ 9.707µ ~ 1.000
SubtreeAllocations/medium_subtrees_data_fetch-4 9.840µ 9.889µ ~ 1.000
SubtreeAllocations/medium_subtrees_full_validation-4 19.27µ 19.31µ ~ 1.000
SubtreeAllocations/large_subtrees_exists_check-4 2.311µ 2.320µ ~ 1.000
SubtreeAllocations/large_subtrees_data_fetch-4 2.395µ 2.424µ ~ 0.700
SubtreeAllocations/large_subtrees_full_validation-4 4.830µ 4.781µ ~ 0.700
_prepareTxsPerLevel-4 401.4m 398.6m ~ 0.700
_prepareTxsPerLevelOrdered-4 3.828m 3.949m ~ 0.700
_prepareTxsPerLevel_Comparison/Original-4 404.7m 398.2m ~ 0.100
_prepareTxsPerLevel_Comparison/Optimized-4 3.599m 4.178m ~ 0.100
_BufferPoolAllocation/16KB-4 3.631µ 4.682µ ~ 0.100
_BufferPoolAllocation/32KB-4 10.649µ 9.958µ ~ 1.000
_BufferPoolAllocation/64KB-4 18.10µ 16.36µ ~ 0.100
_BufferPoolAllocation/128KB-4 35.91µ 31.60µ ~ 0.100
_BufferPoolAllocation/512KB-4 117.0µ 132.0µ ~ 0.100
_BufferPoolConcurrent/32KB-4 21.22µ 20.29µ ~ 0.400
_BufferPoolConcurrent/64KB-4 29.56µ 30.16µ ~ 0.100
_BufferPoolConcurrent/512KB-4 150.8µ 157.5µ ~ 0.100
_SubtreeDeserializationWithBufferSizes/16KB-4 602.3µ 649.8µ ~ 0.100
_SubtreeDeserializationWithBufferSizes/32KB-4 574.2µ 576.0µ ~ 0.700
_SubtreeDeserializationWithBufferSizes/64KB-4 577.9µ 553.6µ ~ 0.100
_SubtreeDeserializationWithBufferSizes/128KB-4 570.7µ 569.3µ ~ 1.000
_SubtreeDeserializationWithBufferSizes/512KB-4 578.2µ 575.3µ ~ 0.200
_SubtreeDataDeserializationWithBufferSizes/16KB-4 34.05m 34.22m ~ 0.400
_SubtreeDataDeserializationWithBufferSizes/32KB-4 34.04m 33.98m ~ 0.400
_SubtreeDataDeserializationWithBufferSizes/64KB-4 33.92m 34.01m ~ 0.400
_SubtreeDataDeserializationWithBufferSizes/128KB-4 34.25m 34.08m ~ 0.400
_SubtreeDataDeserializationWithBufferSizes/512KB-4 33.98m 34.28m ~ 1.000
_PooledVsNonPooled/Pooled-4 896.3n 901.2n ~ 0.200
_PooledVsNonPooled/NonPooled-4 8.137µ 7.745µ ~ 0.100
_MemoryFootprint/Current_512KB_32concurrent-4 8.085µ 7.346µ ~ 0.700
_MemoryFootprint/Proposed_32KB_32concurrent-4 9.882µ 11.389µ ~ 0.100
_MemoryFootprint/Alternative_64KB_32concurrent-4 9.755µ 10.126µ ~ 0.100
StoreBlock_Sequential/BelowCSVHeight-4 361.7µ 300.8µ ~ 0.400
StoreBlock_Sequential/AboveCSVHeight-4 354.6µ 366.5µ ~ 0.400
GetUtxoHashes-4 261.4n 265.4n ~ 0.700
GetUtxoHashes_ManyOutputs-4 43.53µ 44.02µ ~ 0.200
MetaBytes-4 89.24n 89.84n ~ 0.200
_NewMetaDataFromBytes-4 284.6n 281.7n ~ 1.000
_Bytes-4 397.1n 391.9n ~ 0.100
_MetaBytes-4 138.6n 139.6n ~ 0.100

Threshold: >10% with p < 0.05 | Generated: 2026-09-01 19:34 UTC

@ordishs
ordishs requested review from liam and oskarszoon September 2, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liam liam Awaiting requested review from liam
@oskarszoon oskarszoon Awaiting requested review from oskarszoon

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ordishs