fix(p2p): cap broadcast goroutines with bounded semaphore#775
Open
ordishs wants to merge 1 commit intobsv-blockchain:mainfrom
Open
fix(p2p): cap broadcast goroutines with bounded semaphore#775ordishs wants to merge 1 commit intobsv-blockchain:mainfrom
ordishs wants to merge 1 commit intobsv-blockchain:mainfrom
Conversation
Contributor
|
🤖 Claude Code Review Status: Complete Summary: The implementation is solid and addresses the OOM issue effectively. The semaphore pattern correctly caps in-flight goroutines, and the test verifies the behavior with appropriate timing assertions. Observations: Minor - Test timing flexibility: The test uses a 2-second buffer for expectedMax (line 687 in test file). On slow CI runners or under heavy load, this might occasionally fail. Consider increasing the buffer or adding a note if flakiness occurs. Positive highlights:
|
|
Contributor
Benchmark Comparison ReportBaseline: Current: Summary
All benchmark results (sec/op)
Threshold: >10% with p < 0.05 | Generated: 2026-04-28 20:23 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4574.
Summary
clientChannelMap.broadcastspawned one goroutine per client per message with no concurrency cap. Under a notification burst with many clients (256 clients × 100 msg/sec ≈ 25,600 goroutines/sec, plus per-goroutine timers), the resource pressure can OOM the node.Fix
Adds a fixed-size
chan struct{}semaphore (default 256 slots) that caps in-flight broadcast goroutines. The send-with-timeout logic inside each goroutine is unchanged.Test plan
(N / poolSize) * timeoutrather than the un-boundedtimeout(proves the semaphore actually serialises).go test -race ./services/p2p/...passes.