refactor(wallet-toolbox): address S7059 async constructors in Monitor/SimpleWallet/CWIStyle#106
Open
refactor(wallet-toolbox): address S7059 async constructors in Monitor/SimpleWallet/CWIStyle#106
Conversation
…/SimpleWallet/CWIStyle Resolve Sonar S7059 (async work in constructors) for Monitor, SimpleWalletManager, and CWIStyleWalletManager by adopting the .ready: Promise<void> pattern. Each class now exposes a public `ready` property that resolves once async initialization (chain subscriptions or snapshot loading) completes, keeping the constructor itself synchronous. Monitor uses Promise.all for concurrent subscription awaiting. Update CWIStyleWalletManager test to await ready before inspecting loaded state. Refs #38 #45. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sonar still flagged \`this.ready = this.loadSnapshot(...)\` because the assignment invokes an async method from the constructor body. Switch to lazy memoized getter: constructor stores init args, ready getter triggers init on first access. Public API unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@bsv/wallet-toolboxMonitor: movessubscribeReorgs/subscribeHeaderscalls from the constructor into aready: Promise<void>using an async IIFE; subscriptions awaited concurrently viaPromise.allSimpleWalletManager: constructor previously silently dropped theloadSnapshotpromise; now assigned toreadyCWIStyleWalletManager: constructor calledloadSnapshot(...).catch(...)inline; refactored toreadyso callers can track completioncurrentUMPTokenwithout awaiting the snapshot load toawait manager.readyfirstRefs #38 #45
Test plan
pnpm --filter @bsv/wallet-toolbox run build— cleanpnpm --filter @bsv/wallet-toolbox exec jest --runInBand 'CWIStyleWalletManager'— 38 passedpnpm --filter @bsv/wallet-toolbox exec jest --runInBand 'test/monitor/Monitor'— 14 passed🤖 Generated with Claude Code