Allow internalizing sending transactions#228
Merged
Merged
Conversation
sirdeggen
approved these changes
Jun 24, 2026
…point flakiness; sync JSDoc and comments for 'sending' status support
d180ac4 to
f9e40fc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Security / settlement semantics
internalizeActionstill validates the AtomicBEEF and txid before storage mutation.sendingpath is only a merge into an existing same-user transaction record that Storage already knows by txid.sending; it is not promoted tounprovenorcompleted, and the existing monitor/posting flow remains responsible for advancing or failing it.createActionfunding excludessendingoutputs. Delayed/chained flows can includesendingoutputs by design, matching the existing pending-chain policy.accepted: true, so callers should interpret this as "accepted into wallet/storage state," not network settlement. A future API improvement should expose pending vs settled status explicitly.Validation