Skip to content

Conversation

@napoly
Copy link
Member

@napoly napoly commented Dec 21, 2025

This PR was created after extensive discussions with @deverickapollo and is partially influenced by the following pull requests:

The primary goal of this change is to streamline our deployment process and minimize friction when moving to production.

Changes included in this PR:

  • Deprecates wallet passwords due to the inability to fully separate the password file from the wallet file.
  • Renames MoneroRPCProvider to MoneroRpcProvider for consistency.
  • Adds automatic wallet migration and load-up when the wallet is successfully found, with integration tests.
  • Reverts the view_wallet name back to wallet to simplify migration.
  • Introduces some helper functions for testing in IntegrationTestUtils.
  • Updates the btcpayserver submodule.
  • Requires a follow-up change in the btcpayserver-docker PR #1035
    to migrate from --wallet-file=/wallet/wallet --password-file=/wallet/password to --wallet-dir=/wallet.

@napoly napoly force-pushed the load-wallet-on-start-up-if-available branch 2 times, most recently from 1464fa9 to 32d0265 Compare December 21, 2025 16:45
@codacy-production
Copy link

codacy-production bot commented Dec 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.00% (target: -1.00%) 89.29%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e17d930) 979 563 57.51%
Head commit (a3f5d30) 993 (+14) 581 (+18) 58.51% (+1.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#65) 56 50 89.29%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@napoly napoly force-pushed the load-wallet-on-start-up-if-available branch 2 times, most recently from e1d46a5 to 877411c Compare December 22, 2025 09:20
@napoly napoly force-pushed the load-wallet-on-start-up-if-available branch 3 times, most recently from bec6e9c to 28795f8 Compare January 13, 2026 13:12
@napoly napoly force-pushed the load-wallet-on-start-up-if-available branch 5 times, most recently from e243f61 to 243c3a1 Compare January 17, 2026 16:10
@napoly napoly force-pushed the load-wallet-on-start-up-if-available branch from 243c3a1 to a3f5d30 Compare January 18, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant