-
Notifications
You must be signed in to change notification settings - Fork 417
Add Doc Page and Fix Ambiguous Language #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SeaSquared24
wants to merge
14
commits into
btcpayserver:master
Choose a base branch
from
SeaSquared24:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions for how to save your env vars to a source file which can be reloaded to your session without pasting individual lines or remembering what configs you modified when you first set up the server.
Fix ambiguity in Step 8 and add link to save-env-vars.md in two places.
Added more detail to the Basic Way section
Add link to save-env-vars.md. Fix typo.
Add reference to save-env-vars.md
Add reference to save-env-vars.md
add reference to save-env-vars.md
add reference to save-env-vars.md
add reference to save-env-vars.md
simplified my original changes.
add reference to save-env-vars.md
wongsrisuthi6
approved these changes
Oct 28, 2025
wongsrisuthi6
approved these changes
Oct 28, 2025
Author
|
I see this was approved 2 weeks ago. I was wondering what was holding up the actual merge? (I'm new to this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was asked to do this after going through some headaches when I deployed my btcpay server.
Changes are:
* Reword ambiguous language in step 8 of the cloudflaretunnel doc
* Create save-env-vars.md to explain how to create a source file to save environment variables so that re-exporting them is a snap when modifying the deployment
* Add reference to this new doc in all other docs that mention environment variables