btcutil, main: fix android builds#2461
Open
kcalvinalvin wants to merge 4 commits intobtcsuite:masterfrom
Open
Conversation
Golang's net package has been broken for android since android 11 and the node will not be able to call net.InterfaceAddr() without root. For android builds, we use anet so that the btcd node can be used without root.
We update go.mod and go.sum to point to the local btcutil library. This commit should be updated later on so that we do it right.
We use this as the net.InterfaceAddr is broken from android 11.
Pull Request Test Coverage Report for Build 19308219956Details
💛 - Coveralls |
Roasbeef
approved these changes
Dec 18, 2025
|
|
||
| go 1.23.2 | ||
|
|
||
| replace github.com/btcsuite/btcd/btcutil => ./btcutil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
For android since version 11,
net.InterfaceAddrs()has been broken.This means that while btcd will build fine on android, it won't run as the logs show below:
So if we're building on Android, we use the alternate net library called anet.
I specifically use my own fork to utilize wlynxg/anet#9 as the master branch requires an extra build flag.
Steps to Test
1: Download Termux on an Android device.
2: Clone btcd.
3: Build.
4: Run to see if it works.
Pull Request Checklist
Testing
Code Style and Documentation
📝 Please see our Contribution Guidelines for further guidance.