Skip to content

bug fixes #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bug fixes #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c209cc3
fix(packages): ignore node_modules, set bower path
Sep 22, 2014
a166d53
fix(makeHtml): trim space before parse it to html
Sep 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .bowerrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"directory": "bower_components"
}
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
bower_components/
node_modules
3 changes: 2 additions & 1 deletion markdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ angular.module('btford.markdown', ['ngSanitize']).
element.html(html);
});
} else {
var html = $sanitize(markdownConverter.makeHtml(element.text()));
var rtrim = /^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g;
var html = $sanitize(markdownConverter.makeHtml(element.text().replace(rtrim, '')));
element.html(html);
}
}
Expand Down
6 changes: 6 additions & 0 deletions markdown.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ describe('btfMarkdown', function () {
expect(elt.html()).toBe('<p><em>hi</em></p>');
});

it('should trim spaces', function () {
var elt = angular.element('<btf-markdown> *hi* </btf-markdown>');
$compile(elt)($rootScope);
expect(elt.html()).toBe('<p><em>hi</em></p>');
});

it('should work as an attribute', function () {
var elt = angular.element('<div btf-markdown>*hi*</div>');
$compile(elt)($rootScope);
Expand Down