add: example/BuddySpMM #493
Conversation
examples/BuddySpMM/makefile
Outdated
| -finalize-memref-to-llvm \ | ||
| -reconcile-unrealized-casts | \ | ||
| ${MLIR_CPU_RUNNER} ${OPT_FLAG} -e main -entry-point-result=void \ | ||
| -shared-libs=${MLIR_RUNNER_UTILS} -shared-libs=${MLIR_C_RUNNER_UTILS} |
There was a problem hiding this comment.
Please add an empty line here.
There was a problem hiding this comment.
Please add more comments to describe this example and the kernel implementation.
| // RUN: | mlir-cpu-runner -e main -entry-point-result=void \ | ||
| // RUN: -shared-libs=%mlir_runner_utils_dir/libmlir_runner_utils%shlibext \ | ||
| // RUN: -shared-libs=%mlir_runner_utils_dir/libmlir_c_runner_utils%shlibext \ | ||
| // RUN: | FileCheck %s |
There was a problem hiding this comment.
You are using FileCheck to verify the example, but you missed the specific CHECK item.
Please see here as an example.
examples/BuddySpMM/verify_spmm.py
Outdated
There was a problem hiding this comment.
Please verify the correctness with FileCheck instead of a Python program.
There was a problem hiding this comment.
examples/BuddySparse may be a more appropriate directory name for your example, as we can add more sparse kernels in this location.
|
@zhanghb97 Thank you very much for taking the time to review my code and provide valuable suggestions.I have made modifications based on your suggestions.f153080 |
To support more examples, I have implemented the example/BuddySpMM, which calculates sparse matrix multiplication through a three-layer loop.