Skip to content

Conversation

ArCyanic
Copy link
Contributor

There are two minor issue when I add VIR python binding.

  1. Naming Consistancy in midend/lib/CAPI/CMakeLists.txt
    For other dialects like rvv, they have a prefix Buddy, but for VectorExp dialect, it doesn't.
  2. Redundent inclusion in midend/lib/CAPI/Dialects.cpp
    There is no need to include xxxOps.h. I've deleted them all and rebuild, then passed all tests still.

If these two suggestions were to accepted, I'll add a commit to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant