Switch test of attachment to always use integer as ID.

bueltge · Sep 13, 2019 · b2d650b · b2d650b
1 parent e8e31bc
commit b2d650b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Site.php b/src/Site.php
@@ -11,7 +11,7 @@ class Site
     const SITE_ID = 'global_media.site_id';
     const META_KEY_SITE_ID = 'global_media_site_id';
 
-    const SITE_ID_PREFIX_RIGHT_PAD = '00000';
+    const SITE_ID_PREFIX_RIGHT_PAD = 00000;
 
     /**
      * Return the ID of site that store the media files.

diff --git a/tests/php/unit/AttachmentTest.php b/tests/php/unit/AttachmentTest.php
@@ -31,10 +31,10 @@ public function testPrepareAttachmentForJs()
         $site
             ->expects($this->once())
             ->method('idSitePrefix')
-            ->willReturn('1' . Site::SITE_ID_PREFIX_RIGHT_PAD);
+            ->willReturn(1 . Site::SITE_ID_PREFIX_RIGHT_PAD);
 
         $attachmentDataMock = [
-            'id' => 'ID',
+            'id' => '',
             'editLink' => true,
             'nonces' => [
                 'update' => true,
@@ -43,7 +43,7 @@ public function testPrepareAttachmentForJs()
             ],
         ];
         $attachmentDataExpected = [
-            'id' => '1' . Site::SITE_ID_PREFIX_RIGHT_PAD . 'ID',
+            'id' => intval(1 . Site::SITE_ID_PREFIX_RIGHT_PAD),
             'editLink' => false,
             'nonces' => [
                 'update' => false,