Improve support for running on push event#1
Open
andrewmcnamara wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves support for push events. Original issue that has been closed unresolved
On initial PR creation the base_ref is null .
{ "after": "41da3d31e13c738899d9b167156d4[22](https://github.com/andrewmcnamara/jacoco-playground/actions/runs/6347324298/job/17242166029#step:7:23)875194b15", "base_ref": null, "before": "0000000000000000000000000000000000000000", }This causes
client.rest.repos.compareCommitsingetChangedFilesto fail withHttpError: Not Foundas the base ref is not found.This PR surrounds this call with a try/catch and additionally makes an assumption that what you really want is to compare against your default branch. Which is correct in most cases.