Skip to content

Updates for Login to log in and logout to log out#562

Merged
RRudder merged 6 commits into
masterfrom
grammar-fix-login-logout
Jul 28, 2025
Merged

Updates for Login to log in and logout to log out#562
RRudder merged 6 commits into
masterfrom
grammar-fix-login-logout

Conversation

@RRudder

@RRudder RRudder commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

This addresses Issue #445 of the VRT repo - bugcrowd/vulnerability-rating-taxonomy#445

Thanks @Phishician for the detailed review!

@nnons

nnons commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

@abhinav-nain why is this test failing can you help us on this one?

"Because the current Bundler version (2.7.1) does not satisfy bundler ~> 2.6.3
  and Gemfile depends on bundler ~> 2.6.3,
  version solving has failed."
@RRudder

RRudder commented Jul 24, 2025

Copy link
Copy Markdown
Contributor Author

@nnons This linting error is now fixed 👍

@nnons nnons self-requested a review July 28, 2025 19:49

@nnons nnons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RRudder RRudder merged commit 15bb7f8 into master Jul 28, 2025
4 checks passed
@RRudder RRudder deleted the grammar-fix-login-logout branch July 28, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants