Skip to content

Added a new plugin-react-native-remote-spans module #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented May 29, 2025

Goal

Introduced a new plugin-react-native-remote-spans with skeleton TurboModule

Testing

Manually tested

@lemnik lemnik force-pushed the PLAT-14252/rn-remote-spans branch from e86227a to 1bb76e7 Compare May 29, 2025 16:22
Copy link

github-actions bot commented May 29, 2025

Browser bundle size

NPM build

Package
Before 217.95 kB
After 217.95 kB
± No change

CDN build

Unminified Minfied Minified + gzipped
Before 110.02 kB 41.96 kB 12.27 kB
After 110.02 kB 41.96 kB 12.27 kB
± No change No change No change

Code coverage

Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ /home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/plugin-react-native-remote-spans/dist/NativeBugsnagRemoteSpans.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)
🔴 ✨ /home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/plugin-react-native-remote-spans/lib/NativeBugsnagRemoteSpans.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)
🔴 ✨ /home/runner/work/bugsnag-js-performance/bugsnag-js-performance/packages/plugin-react-native-remote-spans/lib/index.ts 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)

Total:

Lines Branches Functions Statements
82.62%(-0.71%) 59.77%(-0.42%) 73.79%(-0.68%) 78.78%(-0.86%)

Generated against 0be85d0 on 2 June 2025 at 14:09:35 UTC

Comment on lines 30 to 31
"@testing-library/react-native": "^12.4.1",
"react-native-navigation": "7.37.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@testing-library/react-native": "^12.4.1",
"react-native-navigation": "7.37.2"
"@testing-library/react-native": "^12.4.1"

yousif-bugsnag
yousif-bugsnag previously approved these changes May 30, 2025
Copy link
Contributor

@yousif-bugsnag yousif-bugsnag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unused dev dependency, but otherwise LGTM

@lemnik lemnik merged commit 6c1013d into integration/span-controls Jun 3, 2025
10 checks passed
@lemnik lemnik deleted the PLAT-14252/rn-remote-spans branch June 3, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants