Skip to content

Remove misleading type definition #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Remove misleading type definition #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/core/types/client.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import Breadcrumb from './breadcrumb'
import {
NotifiableError,
BreadcrumbType,
OnErrorCallback,
OnSessionCallback,
Expand All @@ -16,7 +15,7 @@ declare class Client {

// reporting errors
public notify(
error: NotifiableError,
error: Error,
onError?: OnErrorCallback,
cb?: (err: any, event: Event) => void
): void;
Expand Down
5 changes: 0 additions & 5 deletions packages/core/types/common.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,6 @@ export interface SessionPayload {
sessions: Session[]
}

export type NotifiableError = Error
| { errorClass: string, errorMessage: string }
| { name: string, message: string }
| string

export type BreadcrumbType = 'error' | 'log' | 'manual' | 'navigation' | 'process' | 'request' | 'state' | 'user';

interface Device {
Expand Down