Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @bugsnag/core/lib/es-utils/map #2336

Open
wants to merge 5 commits into
base: plat-12947-8
Choose a base branch
from
Open

Conversation

djskinner
Copy link
Contributor

@djskinner djskinner commented Feb 17, 2025

Remove @bugsnag/core/lib/es-utils/map replacing with builtin Array.map. As we have dropped very old IE support these are no longer necessary and hopefully removing them will improve the bundle size a bit. Furthermore for things that aren't supported by our target browserslist babel will provide the appropriate helpers/polyfills so we're able to write modern source and browser compatibility is handled automatically

This reverts commit fc89d05.
Copy link

github-actions bot commented Feb 17, 2025

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 56.68 kB 17.24 kB
After 56.37 kB 17.14 kB
± -311 bytes -101 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against c04af92

@djskinner djskinner marked this pull request as ready for review March 20, 2025 14:01
Comment on lines +6 to +10
...schema.releaseStage, ...{
defaultValue: () => {
if (/^localhost(:\d+)?$/.test(window.location.host)) return 'development'
return 'production'
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the second spread object here unnecessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants