Address Non-Standard Baud Rate Caching #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d speed is stored in serial attributes
|
@jalius why are you @-mentioning me? I can subscribe to the notifications that I'm interested in, so why spam me? |
|
Why not use |
I don't have a strong opinion on this. Can we make a strong case for either value as a default? In the end, the value is overwritten by the subsequent syscall in setSpecialBaudRate. |
It just was a value that was unexpected, which caught my eye. No particular reason. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #207.
Fixes a case where read-modify-write of serial settings fails in
serial.Open()andserial.Port.SetMode()when a non-standard baud rate is returned by the OS via getTermSettings, ultimately causing setTermSettings to fail with EINVAL.