Skip to content

Changes CoefficientsX to CoefficientsY #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RickBrice
Copy link

CoefficientsX are limited to CoefficientsX[0] and CoefficientsX[1].

The correct coefficient for y = a*x^2 is CoefficientsY[3]

CoefficientsX are limited to CoefficientsX[0] and CoefficientsX[1].

The correct coefficient for y = a*x^2 is CoefficientsY[3]
@SergejMuhic
Copy link
Contributor

I have to disagree, but also with the original. My proposal:
y = ax^2 + by + c

is CoefficientsX[3]=a, CoefficientsX[2]=b, CoefficientsX[1]=c and CoeffiecientsY[2]=1.

@aothms
Copy link
Collaborator

aothms commented Apr 2, 2025

Thanks for spotting this, I agree with Sergej but, oh dear, the "semantic definition" on the entity does not help us much.

afbeelding

afbeelding

Also looping in @civilx64 and @evandroAlfieri for the validation service because there are some "informal propositions" hidden in the text here (which are indeed wrong, X/Y should be swapped)

  • The size of the attribute CoefficientsY (sic) is restricted to 3 [. The quadratic term is on position 3]
  • [In general,] the CoefficientsX (sic) size would be restricted to 2 and values specified as [0, 1].

I would format these in the text as a bullet list so that they stand out a bit more.

Actions:

  • Adapt example to Sergej's (and format using latex)
  • Swap text X <-> Y
  • Reformat text
  • Provide some entity and attribute definition on the entity page
  • Implement rule in VS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants