Prevent catching intentional errors (IVS-371) - #345
Draft
Ghesselink wants to merge 3 commits into
Draft
Conversation
Ghesselink
marked this pull request as draft
January 29, 2025 23:03
civilx64
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were catching intentional errors as unintentional exceptions due to
https://github.com/buildingSMART/ifc-gherkin-rules/pull/329/files#diff-2c838ec4f24dc4e43b898ddaa7de4de8f6cc972099850db514753312625e105a
The two types were distinguished by the output string (i.e. if the string contained
'Behave errors'the error is intentional), it is probably better to store this information in the behave context instead.