Skip to content

fix: use mapping env syntax in Buildkite pipelines #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wolfeidau wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use mapping env syntax in Buildkite pipelines #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ae68e
fix: use mapping env syntax in Buildkite pipelines
wolfeidau Jun 2, 2026
a93d2e3
fix: remove cache env
wolfeidau Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline.release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ steps:
- "linux"
- "windows"
env:
- GOOS={{matrix}}
GOOS: "{{matrix}}"
artifact_paths:
- dist/**/*
plugins:
Expand Down
17 changes: 1 addition & 16 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,12 @@ image: "buildkite/hosted-agent-base-images:ubuntu-jammy"
agents:
queue: hosted

cache:
name: "golang-cache"
paths:
- "~/gocache"
- "~/gomodcache"
size: "100g"

steps:
Copy link
Copy Markdown

@buildsworth-bk-app buildsworth-bk-app Bot Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: This also removes the top-level cache: block and the GOCACHE/GOMODCACHE env vars, which is a bit wider than the title suggests. My guess is those vars never took effect under the old list syntax (same bug as GOOS), so ~/gocache/~/gomodcache were never populated and the caching was effectively a no-op. Is the intent to drop Go build/module caching for good, or is wiring it back up with the mapping syntax a follow-up?

- group: ":mag: Quality Checks"
key: quality-checks
steps:
- name: ":golangci-lint: lint"
command: golangci-lint run --verbose --timeout 3m
env:
- GOCACHE=~/gocache
- GOMODCACHE=~/gomodcache
plugins:
- mise#v1.1.1: ~

Expand All @@ -29,19 +19,14 @@ steps:
- go test -coverprofile cover.out ./...
- go run github.com/nikolaydubina/go-cover-treemap@latest -coverprofile cover.out > cover-tree.svg
- echo '<details><summary>Coverage tree map</summary><img src="artifact://cover-tree.svg" alt="Test coverage tree map" width="70%"></details>' | buildkite-agent annotate --style "info"
env:
- GOCACHE=~/gocache
- GOMODCACHE=~/gomodcache
plugins:
- mise#v1.1.1: ~

- label: ":terminal: build ({{matrix}})"
command: ".buildkite/release.sh release --clean --snapshot --split"
depends_on: quality-checks
env:
- GOCACHE=~/gocache
- GOMODCACHE=~/gomodcache
- GOOS={{matrix}}
GOOS: "{{matrix}}"
matrix:
- "darwin"
- "linux"
Expand Down